chore!: Remove deprecated client Init() function #353
Conversation
|
Fixes #208 Hang on, let me see what's up with the tests.... |
There was a problem hiding this comment.
#208 (comment) talks about renaming InitLocal() --> Init(), is there a reason we shouldn't do that?
This is already a breaking change and the function signatures are different, so it should be relatively easy to figure out how to change Init() calls.
@haydentherapper as the author of InitLocal(), wdyt?
@hosseinsia @ethan-lowman-dd any thoughts on this?
|
Good call! I might prefer to do that in a follow-up PR, which will be very very easy to write/review. |
Agreed |
trishankatdatadog
force-pushed
the
rminit
branch
from
a096bdf to
5986295
Compare
|
Easy to review follow-up PR works for me, thanks. |
Has been deprecated for a release or so. This fixes some tests and removes others; the removals are all justified: - TestInitRootExpired: testing of InitLocal checks the behavior on expired roots (which is *different*; it allows expired roots) - TestInitRootTooLarge: covered now in TestUpdate We also add a "RawMeta" function, used to get at the root json. I could be persuaded that this should be a "RawRoot" instead. BREAKING CHANGE: remove client.Init() in favor of InitLocal() Signed-off-by: Zachary Newman <[email protected]>
Signed-off-by: Zachary Newman <[email protected]>
|
Had to rebase so I need another round of approvals, sorry! |
|
FYI, follow-up here to rename "InitLocal" to "Init": #354 |
Has been deprecated for a release or so.
This fixes some tests and removes others; the removals are all
justified:
expired roots (which is different; it allows expired roots)
We also add a "GetMeta" function, used to get at the root json.
BREAKING CHANGE: remove client.Init() in favor of InitLocal()
Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #
Release Notes:
Types of changes:
Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: